Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add log to help debug #6987

Merged
merged 3 commits into from
Aug 30, 2023
Merged

*: add log to help debug #6987

merged 3 commits into from
Aug 30, 2023

Conversation

CabinfeverB
Copy link
Member

@CabinfeverB CabinfeverB commented Aug 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4399

What is changed and how does it work?

find a log

[2023/08/03 17:50:41.638 +05:30] [INFO] [lease.go:113] ["lease timeout"] [expire=2023/08/03 17:50:43.637 +05:30] [purpose="pd leader election"]
expire time is later than the log time. Add print start_time to help debug.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@CabinfeverB
add log
5e20e57 
Signed-off-by: Cabinfever_B <[email protected]>
@CabinfeverB
add log
b9e4392 
Signed-off-by: Cabinfever_B <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 25, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and nolouch August 25, 2023 10:02
@CabinfeverB CabinfeverB requested review from lhy1024 and rleungx and removed request for nolouch and HunDunDM August 25, 2023 10:02
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #6987 (8039305) into master (9a574ed) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6987      +/-   ##
==========================================
- Coverage   74.33%   74.18%   -0.16%     
==========================================
  Files         433      433              
  Lines       46097    46097              
==========================================
- Hits        34265    34195      -70     
- Misses       8830     8884      +54     
- Partials     3002     3018      +16
Flag Coverage Δ
unittests 74.18% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2023
HuSharp
HuSharp approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 28, 2023
@CabinfeverB
fix
8039305 
Signed-off-by: Cabinfever_B <[email protected]>
@CabinfeverB
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8039305

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit e0a4103 into tikv:master Aug 30, 2023
@CabinfeverB CabinfeverB deleted the add_log branch August 30, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CabinfeverB @lhy1024 @HuSharp